Consolidating e2e tests to use new getEntriesAndErrors #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongrich
approved these changes
Sep 22, 2023
|
Oh, I didn't realize I was the only one with merge privileges! I have just added the rest of the team to the repo as owners as well, for the future. |
ajhyndman
force-pushed
the
kada/cleanup-tests
branch
from
0505549
to
ed5752b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it
In one of the previous PRs (#77), I have introduced
getEntriesAndErrorsas a way to get both errors and measurements for TTVC.There is likely no point in us keeping both
getEntriesandgetEntriesAndErrorsmethods - so I am consolidating the remainder of the tests to usegetEntriesAndErrors.What's the difference?
getEntriesreturns successful measurements that TTVC has madegetEntriesAndErrorsreturns both errors/cancellations and succesful measurementsTesting
No impact on the runtime - only on e2e tests ran with
yarn test:e2e.